Fixing MAX_JOBS in Dockerfile, resolving issue #91 #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej,
after running into OOM, I fixed the MAX_JOBS issue #91. The only file that needed to be modified is the Dockerfile.
Explanation
Build arguments (ARG) are only visible at Dockerfile level, they're not passed through into the container. Therefor MAX_JOBS needs to be passed to the container as environment variable which only can be done bei ENV. That, on the other hand, cannot be overriden by a command line option like "--build-arg" (there's no "--build-env").
To be configurable, it needs to be defined as ARG first and then set with ENV while refering to the ARG:
Med hilsen fra Danmark